ApplicationException during deserialization of toolbar layout

Hi Tobias,

Good find... since we call a "reader.Skip()" in that ValidateCommandName, it's reading an extra XML element that it shouldn't be.  To confirm with you, you just commented out that particular line and everything works properly since ValidateCommandName still returns a boolean indicating validation success, right?

Correct, thats what I did. That solved this particulary issue. However I suppose you have more insights on whether or not there are other use cases. The method ValidateCommandName() is used in four places, but I only checked one (DockableToolbar). I just assumend the others would behave the same way.

Hi Tobias,

All three places ValidateCommandName is called seem to be called the same way.  But after examining it again, I wonder if we need to handle scenarios where there could be nested tags within the one being examined.  In that case, we'd need to likely skip over them.

Could you try changing that "reader.Skip()" line in ValidateCommandName to:

// If the current node is not empty...
if (!reader.IsEmptyElement) {
	// Store the depth and advance
	int depth = reader.Depth;
	reader.Read();

	// Loop while the depth is below the initial depth
	while ((!reader.EOF) && (reader.Depth > depth))
		reader.Read();
}

Please let me know if that works for your scenario.

That works too. In my scenario the command links don't have any nested tags.

Hi Tobias,

Thanks, we've updated our code for the next maintenance release to match the above.