Couple of minor visual issues in Sample Browser

SyntaxEditor for WPF Forum

Posted 5 months ago by Dirk Zellerfeld
Version: 19.1.0680
Platform: .NET Core 3.0
Environment: Windows 10 (64-bit)
Avatar

I've noticed some minor visual issues in Sample Browser when using the metro dark theme.

1. In chapter 10 - Intellisense Completion List the icons at the menu bar have the same color as in metro light which makes them hard to see. This also applies to any other chapter which has menu icons.

2. In same chapter when you open intellisense the tooltip for each entry has the same color as in metro light which means white background and black text. Same in insert snippet chapter and others.

3. In "Completion Filtering" chapter when you open the completion list in metro dark theme the menu at the bottom is unreadable since the forecolor of the text remains black.

4. If you start the sample browser and switch to Metro Dark immediately and then open the "Current Line Highlighting" chapter everything is okay so far. If you then switch to metro light the line highlighting color in the editor has changed although in menu it doesn't. Moreover if you try to change the color in the menu then nothing happens. You can check on / off the checkbox next to it but still nothing happens. When you switch a page back and then forward the line highlighting color is set to transparent. If you change it now it works.

5. Not an issue but I think a chapter demonstrating the multiple carets would be amazing since this is clearly an outstanding feature. It could let potential customers get aware of it and try it out.

Comments (1)

Answer - Posted 5 months ago by Actipro Software Support - Cleveland, OH, USA
Avatar

Hi Dirk,

1) Yes, the menu/toolbar icons in the samples currently only have been designed for light backgrounds.  I'll mark down the suggestion to try and improve them for dark backgrounds.

2) Very good find... this one is tricky.  The logic that retrieves images and IntelliPrompt text content is not contextual in any way.  Right now the images pull based on theme and the IntelliPrompt text content is generally hard-coded to colors assuming a light theme.  We are going to make updates for the next build to render quick info and parameter info tips with the same syntax highlighting used in the main editor, and will have a similar background to the editor as well.  That should resolve this.

3) Thanks, we needed to add a Foreground setter for the tab items to the current theme foreground.  We've updated this for the next build.

4) This is because the theme change is indirectly causing the ambient highlighting style registry to be updated elsewhere in the sample project with brand new styles.  This occurs in App.OnStartup's ThemeManager.CurrentThemeChanged event handler where it calls SyntaxEditorHelper.UpdateHighlightingStyleRegistryForThemeChange.  Since a new style is added there, the binding from the UI of this particular sample is still updating the old style.  Moving to another sample and back will reset it as you saw.  Production apps would want to reset the binding in a ThemeManager.CurrentThemeChanged handler.

5) Good suggestion!


Actipro Software Support

The latest build of this product (v2019.1 build 0683) was released 1 month ago, which was after the last post in this thread.

Add Comment

Please log in to a validated account to post comments.