EditIndicator does not change colors when changing the theme

I tried also this code from the documentation

// Unregister all classification types
var classificationTypes = AmbientHighlightingStyleRegistry.Instance.ClassificationTypes.ToArray();
foreach (var classificationType in classificationTypes)
	AmbientHighlightingStyleRegistry.Instance.Unregister(classificationType);

// Re-register common classification types
new DisplayItemClassificationTypeProvider().RegisterAll();

// NOTE: Possibly load up syntax language instances you use so their various customized styles get registered

but does not work.

Kind regards,

Danil

Hi Daniel,

The caret brush comes from the SyntaxEditor.CaretBrush property.  If that is null, it will use Black or White, depending on the current editor background lightness that it detects.

By default, SyntaxEditor binds its CaretBrush property to the value of the themes:AssetResourceKeys.EditCaretBackgroundNormalBrushKey theme resource.  That theme resource value will come from our Actipro themes.

But if you mean you are only loading a SyntaxEditor dark theme while still in a light Actipro app theme, then the scenario you describe could occur.  In that case, you might want to either set CaretBrush to null or to an appropriate Brush for your SyntaxEditor theme.

This line breaks my coloring:

_ = new DisplayItemClassificationTypeProvider().RegisterAll();

If I remove this line the Indicator Margin will be colored correctly when changing themes.

The thing is I need to register the classification types.

I have only one Theme inside the entire application. I do not use separate themes for the controls.

I also sent a sample on the 'support@actiprosoftware.com'.

Kind regards,

Daniel

One more mention. I change the Document.Language in runtime. The user can change the editor language in runtime :)

Thank you for the sample, that helps a lot.  I think the problem is that you are changing the app theme to dark and that will make the control's Foreground (which ends up being the "plain text" foreground color) and Background (the text area background) go to dark theme colors.  But everything else in the editor, like the indicator margin, modification marks, syntax highlighting is still geared for a light theme.  That's why the indicator margin is still in a lighter color, and the modification mark is too bright.

What you're missing is logic like in our sample's UpdateHighlightingStyleRegistryForThemeChange method.  That will try and update all the display item and other syntax highlighting styles for dark when a dark app theme is loaded.  Please check that out.

Also we know that the updating of SyntaxEditor control theme for app theme changes is tedious right now, and we have a TODO item to work on improving and streamlining that process.

Hi Daniel,

The next release of SyntaxEditor will include native support for light/dark themes tied directly to the application theme by default. Please check out our announcement post if you'd like to validate the new functionality in a preview release and provide feedback before it is finalized.